feat(browserContext): support maximized viewport by dcrousso · Pull Request #42286 · microsoft/playwright

Devin Rousso (dcrousso) · 2026-08-17T21:55:38Z

allow viewport: 'maximized' to maximize native browser windows without a default emulated viewport

keep native maximization independent of browser fullscreen and the web Fullscreen API

preserve the maximized outer window when Page.setViewportSize() enables viewport emulation

github-actions · 2026-08-18T22:33:50Z

🟢 CI is clear — the one failure is a pre-existing Windows flake

Hi, I'm the Playwright bot and I took a look at the failing CI on this PR. The single red test — playwright.trace.spec.ts:434 › should retain traces for interrupted tests on [playwright-test] @windows-latest-node22 — is a known Windows-only flake, unrelated to this PR's windowState change. Nothing here looks caused by the PR.

Details

This PR adds a windowState browser-context option (touching browserContext.ts, crPage.ts, ffBrowser.ts, wkPage.ts, protocol, and headful.spec.ts). It doesn't go near the test runner's trace-retention path that this test exercises.

Pre-existing flake / infra

[playwright-test] › playwright.trace.spec.ts:434 › should retain traces for interrupted tests — flake. In the aggregated CI results it flips verdict only on windows-latest-node22: failed 4 of 658 runs there (~0.6%), passed the other 654, and never fails on any other bot (0 failures across all Linux/macOS runners). The 4 failures are on SHAs this PR can't be responsible for — main (43a91219, 40372734) and PRs feat(test-runner): annotate serial suites for custom sharding #42164 (4e5071fd) and fix(chromium): keep closing the target so page.close() cannot hang on a navigation commit #41912 (21e8d31e), none of which touch windowState. Every failure carries the same signature (expect(received).toBe(expected) / Expected: 1, Received: 0 — a missing trace on a timing-sensitive interrupted-test check), which is the classic shape of this flake. Windows-only, on unrelated SHAs → not PR-specific.

The other 22 tests in the report are within-run flakes (rescued on retry), so there's nothing to triage there.

_{Triaged by the Playwright bot - agent run}

github-actions · 2026-08-18T22:39:30Z

🟢 CI is clear — both failures are pre-existing flakes

Hi, I'm the Playwright bot and I took a look at the failing CI on this PR. Two tests are red across the latest reports — mcp/config.spec.ts:203 › --sandbox enables the sandbox ([chrome]) and playwright.trace.spec.ts:434 › should retain traces for interrupted tests ([playwright-test] @windows-latest-node22). Both are known flakes that fail on SHAs this PR can't be responsible for. Nothing here looks caused by the windowState change.

Details

This PR adds a windowState browser-context option (browserContext.ts, crPage.ts, ffBrowser.ts, wkPage.ts, protocol, docs, and headful.spec.ts). It doesn't touch the MCP config/sandbox flow or the test runner's trace-retention path, so neither red test exercises changed code.

Pre-existing flake / infra

[chrome] › mcp/config.spec.ts:203 › chromiumSandbox › --sandbox enables the sandbox — flake. In the aggregated CI results it flips verdict on other PRs: it fails on fix(mcp): do not ask for roots without the event stream #42300 (e8c62a21) and fix(chromium): stop disabling BoundaryEventDispatchTracksNodeRemoval #42294 (4aa9163c), neither of which touches windowState. Same one-empty-response signature that passes on a re-run. Fails where this PR can't be the cause → not PR-specific.
[playwright-test] › playwright.trace.spec.ts:434 › should retain traces for interrupted tests — flake. It flips only on windows-latest-node22: failed 5 of 4692 runs (~0.1%), passed the other 4687, and never fails on any other bot. The failing SHAs span main (43a91219, 40372734), PRs fix(chromium): keep closing the target so page.close() cannot hang on a navigation commit #41912 (21e8d31e) and feat(test-runner): annotate serial suites for custom sharding #42164 (4e5071fd), and this PR's own SHA (e53f925c) — a timing-sensitive interrupted-test check that also misfires on main. Windows-only, on unrelated SHAs → not PR-specific.

The remaining tests in the reports are within-run flakes (rescued on retry), so there's nothing to triage there.

_{Triaged by the Playwright bot - agent run}

Dmitry Gozman (dgozman) · 2026-09-04T10:48:45Z

+    await context.close();
+  });
+
+  it('should keep native window maximized when resizing viewport', async ({ browser, browserName }) => {


What does this mean for the user? How does it look?

page.setViewportSize() sets a fixed inner viewport without resizing the maximized native window leaving unused space around the 567x345 page

Dmitry Gozman (dgozman) · 2026-09-04T10:51:55Z

+    await context.close();
+  });
+
+  it('should open popups in maximized windows', async ({ browser, browserName, server }) => {


I'd like to also understand the expected behavior of things like "shift+click" that opens a new window, or window.open('', '_blank', 'left=100,top=100,width=320,height=320').

maximizing should override popup geometry for shift-click and explicitly sized window.open()

i've added tests for both

allow `viewport: 'maximized'` to maximize native browser windows without a default emulated viewport keep native maximization independent of browser fullscreen and the web Fullscreen API preserve the maximized outer window when `Page.setViewportSize()` enables viewport emulation

github-actions · 2026-09-04T19:46:30Z

Test results for "tests 1"

8 flaky

⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-leaks.spec.ts:164 › waitFor should not leak `@webkit-ubuntu-22.04-node20`

51356 passed, 1287 skipped

Merge workflow run.

github-actions · 2026-09-04T19:52:40Z

Test results for "MCP"

8327 passed, 1371 skipped

Merge workflow run.

Devin Rousso (dcrousso) requested review from Pavel Feldman (pavelfeldman) and Yury Semikhatsky (yury-s) August 17, 2026 21:55

This comment has been minimized.

Sign in to view

Devin Rousso (dcrousso) force-pushed the fix-1086 branch from 50daf77 to 90c3fcf Compare August 18, 2026 15:33

github-actions Bot mentioned this pull request Aug 18, 2026

fix(chromium): stop disabling BoundaryEventDispatchTracksNodeRemoval #42294

Merged

This comment has been minimized.

Sign in to view

Devin Rousso (dcrousso) force-pushed the fix-1086 branch from 90c3fcf to 58ec01c Compare August 18, 2026 21:42

This comment has been minimized.

Sign in to view

github-actions Bot mentioned this pull request Aug 27, 2026

feat(webkit): roll to r2357 #42437

Closed

Devin Rousso (dcrousso) force-pushed the fix-1086 branch from 58ec01c to 95d42b0 Compare September 3, 2026 22:21

Devin Rousso (dcrousso) changed the title ~~feat(browserContext): add windowState option~~ feat(browserContext): support maximized viewport Sep 3, 2026

This comment has been minimized.

Sign in to view

Dmitry Gozman (dgozman) reviewed Sep 4, 2026

View reviewed changes

Devin Rousso (dcrousso) force-pushed the fix-1086 branch from 95d42b0 to d86a51d Compare September 4, 2026 19:03

Devin Rousso (dcrousso) requested a review from Dmitry Gozman (dgozman) September 4, 2026 19:04

Navigation Menu

Uh oh!

feat(browserContext): support maximized viewport - #42286

feat(browserContext): support maximized viewport#42286
Devin Rousso (dcrousso) wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-1086

Devin Rousso (dcrousso) commented Aug 17, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Aug 18, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Aug 18, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Dmitry Gozman (dgozman) Sep 4, 2026

Uh oh!

Devin Rousso (dcrousso) Sep 4, 2026

Uh oh!

Dmitry Gozman (dgozman) Sep 4, 2026

Uh oh!

Devin Rousso (dcrousso) Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Devin Rousso (dcrousso) commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Aug 18, 2026

🟢 CI is clear — the one failure is a pre-existing Windows flake

Uh oh!

This comment has been minimized.

github-actions Bot commented Aug 18, 2026

🟢 CI is clear — both failures are pre-existing flakes

Uh oh!

This comment has been minimized.

This comment has been minimized.

Dmitry Gozman (dgozman) Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Devin Rousso (dcrousso) Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Dmitry Gozman (dgozman) Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Devin Rousso (dcrousso) Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 4, 2026

Test results for "tests 1"

Uh oh!

github-actions Bot commented Sep 4, 2026

Test results for "MCP"

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Devin Rousso (dcrousso) commented Aug 17, 2026 •

edited

Loading